mtd-utils: various fixes, apply OpenEmbedded patches

[Andrea Adami]

On Wed, Mar 29, 2017 at 3:12 PM, David Oberhollenzer
<david.oberhollenzer at sigma-star.at> wrote:
> As there were no complaints about the patches I posted last week, I
> applied them to mtd-utils.git.
>
>
> On 03/23/2017 11:57 AM, Andrea Adami wrote:
>> Hi,
>> while you're reviewing old patches please note there are some little
>> klibc fixes for 1.52 here:
>>
>> http://cgit.openembedded.org/meta-openembedded/tree/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc
>>
>> Probably you could consider the fixes for rpmatch() and getline(). Unsure about
>> iniparser_getdouble.
>>
>> Thanks
>> Andrea
>>
>
> I took a look at those. The Makefile patches aren't really relevant
> anymore, after the switch to Autotools (also, as noted in the patch,
> the first one is very specific for your use case).
>
> The PRIxoff_t/PRIdoff_t patch (number 4) doesn't apply anymore. From a
> brief look at the log it appears that the format specifies have been
> fixed at least 3 times after the date of your patch. The current
> version uses autoconf to determine the sizeof off_t and loff_t. The
> header sets the format specifers based on the size only, so this
> _should_ make magic libc vendor/feature checks obsolete.
>
> As for the prompt() patch (number 5), the use of rpmatch() has recently
> been removed. I would hesitate removing the use of getline() as proposed
> in the patch, first of all the proposed patch would alter the behavior
> of prompt() if more than one character was entered and second, getline
> has actually been accepted into the standard some ~9 years ago.[1]
>
>
> If there are no objections, I'll apply the libubi ioctl and
> libiniparser patches (number 3 and 6 respectively).
>
>
> Thanks,
>
> David
>
> [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/getdelim.html


David,

thanks for your attention.

I've just pointed these old patches to the attention of the list
because there were other references to mtd 1.5x.
There isn't anything urgent with these klibc specific fixes, just FYI

I'll try to catch up with 2.x, at least the ubi-utils.
For our project we need just kexec-static and for binary size of the
executable klibc is still the best.

To be honest, I have yet to try the static approach with a recent musl
libc like Khem suggested.

Regards
Andrea