[patch] mtd: nand: hynix: Fix an error code in init

Richard Weinberger richard at nod.at
Wed Mar 22 02:53:52 PDT 2017


Am 22.03.2017 um 10:01 schrieb Dan Carpenter:
> We should be return -ENOMEM instead of success.
> 
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/mtd/nand/nand_hynix.c b/drivers/mtd/nand/nand_hynix.c
> index 2a5d0efea498..b12dc7325378 100644
> --- a/drivers/mtd/nand/nand_hynix.c
> +++ b/drivers/mtd/nand/nand_hynix.c
> @@ -270,8 +270,10 @@ static int hynix_mlc_1xnm_rr_init(struct nand_chip *chip,
>  		goto out;
>  
>  	rr = kzalloc(sizeof(*rr) + (nregs * nmodes), GFP_KERNEL);
> -	if (!rr)
> +	if (!rr) {
> +		ret = -ENOMEM;
>  		goto out;
> +	}
>  
>  	for (i = 0; i < nmodes; i++) {
>  		for (j = 0; j < nregs; j++) {
> 

Reviewed-by: Richard Weinberger <richard at nod.at>

Thanks,
//richard



More information about the linux-mtd mailing list