[PATCH v2 6/6] nand: spi: Add generic SPI controller support

Peter Pan peterpansjtu at gmail.com
Wed Mar 8 18:02:03 PST 2017


Hi Boris,

On Wed, Mar 8, 2017 at 4:44 PM, Boris Brezillon
<boris.brezillon at free-electrons.com> wrote:
> On Wed, 1 Mar 2017 16:52:10 +0800
> Peter Pan <peterpandong at micron.com> wrote:
>
>> This commit supports to use generic spi controller
>> as spi nand controller.
>>
>> Signed-off-by: Peter Pan <peterpandong at micron.com>
>> ---
>>  drivers/mtd/nand/spi/Kconfig             |   2 +
>>  drivers/mtd/nand/spi/Makefile            |   1 +
>>  drivers/mtd/nand/spi/chips/Kconfig       |   5 +
>>  drivers/mtd/nand/spi/chips/Makefile      |   1 +
>>  drivers/mtd/nand/spi/chips/generic_spi.c | 158 +++++++++++++++++++++++++++++++
>
> Hm, I would name the directory controllers and not chips. What could go
> into chips are all the vendor specific drivers.

You are right. Should be controllers. Fix this in v3

>
>>  5 files changed, 167 insertions(+)
>>  create mode 100644 drivers/mtd/nand/spi/chips/Kconfig
>>  create mode 100644 drivers/mtd/nand/spi/chips/Makefile
>>  create mode 100644 drivers/mtd/nand/spi/chips/generic_spi.c
>
> Just controllers/generic.c?

generic.c or just spi.c?

Thanks,
Peter Pan



More information about the linux-mtd mailing list