[PATCH] mtd-utils: tests: Add Erased Pages Bit Flip Test

[Harpreet "Eli" Sangha]

On Fri, Jun 30, 2017 at 2:48 PM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Harpreet,
>
> On Thu, Jun 29, 2017 at 4:01 PM, Harpreet Eli Sangha
> <harpreet at nestlabs.com> wrote:
>> From: "Harpreet \"Eli\" Sangha" <harpreet at nestlabs.com>
>>
>> Bit flip detection for written and erased pages tend to have different
>> implementations. Where written pages are detected and corrected using
>> ECC, erased pages are typically detected by ensuring that the number of
>> zeros is less than a specified threshold.
>>
>> As such, it's necessary to have the 'nandbiterrs' test support the
>> testing of written and erased pages. Bit flips in erased pages are
>> emulated by rewriting the page in raw mode, to prevent the use of ECC.
>>
>> Signed-off-by: Harpreet "Eli" Sangha <harpreet at nestlabs.com>
>
> Looks like you missed to add David on Cc once again.
>
> A nitpick: your From and Signed-off-by still do not match.
>
> The From field has two \ character , which is not very common.

Regarding CC'ing David, I didn't realize I was supposed to do that.
I'd assumed you had done it previously as a means of "assigning" the
task to him.  I did not find an official maintainer list and thought
it would be too presumptuous of me to CC him myself rather than
letting it be routed by members of the mail list.

Regarding the backslashes in the From field, it seems something along
the path is deciding to escape quotes in that field.  I will attempt
to address it.

Sorry again.  I will try to resubmit the patch and try to be more
careful in the future.