[PATCH] mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing

Robert Jarzmik robert.jarzmik at free.fr
Sun Jun 11 23:24:04 PDT 2017


Boris Brezillon <boris.brezillon at free-electrons.com> writes:

> Some MTD sublayers/drivers are implementing ->_read/write_oob() and
> providing dummy wrappers for their ->_read/write() implementations.
> Let the core handle this case instead of duplicating the logic.

Hi Boris,

Unless I'm wrong, you're using mtd_oob_ops structures allocated on the
stack. This means they are not filled with 0/NULL at initialization, and
therefore the code is not equivalent to what was before in docg3 for example.

For example, oobbuf field needs initialization. Is it taken care in the core ?

Cheers.

--
Robert



More information about the linux-mtd mailing list