[PATCH v2 0/3] mtd:nor:ppb_unlock fixes

[Honza Petrouš]

Hi Boris.

2017-05-30 15:24 GMT+02:00 Boris Brezillon <boris.brezillon at free-electrons.com>:
> On Tue, 30 May 2017 11:51:07 +0200
> Honza Petrouš <jpetrous at gmail.com> wrote:
>
>> Hi Boris,
>> as you advised I come back with v2 patch, now it is the series
>> of three fixes I found them during the testing of the original fix.
>>
>> From the fixes it is evident that PPB unlocking is not so much
>> widely used. What is understandable as usually the flashing
>> is done in bootloader. At least in projects I was involved before.
>>
>> Anyway, I can say I tested the code only on one-flashchip
>> configuration, so I'm not 100% sure if all will be ok with multichip
>> setting. All my old embedded boards have unfortunatelly only
>> one nor chip.
>
> I think I found another bug here [1]. The test does not work for
> multichip flashes because adr is set back to 0 when you cross a chip
> boundary.
>
> If you want my opinion, you'd better re-code the whole logic (you can
> probably do better, but here is an example [2]).

Yeh, it seems the code has much more issues.

I will try to recode it.

Thanks.

/Honza