[PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2

Boris Brezillon boris.brezillon at free-electrons.com
Fri Jun 2 00:14:44 PDT 2017


On Thu, 1 Jun 2017 17:01:19 +0800
<xiaolei.li at mediatek.com> wrote:

> From: Xiaolei Li <xiaolei.li at mediatek.com>
> 
> Write size in function write_eraseblock2 is subpgsize * k.
> It is wrong to check whether written is equal to subpgsize after each
> mtd_write.
> 
> Signed-off-by: Xiaolei Li <xiaolei.li at mediatek.com>

Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>

> ---
>  drivers/mtd/tests/subpagetest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c
> index aecc6ce..fa2519a 100644
> --- a/drivers/mtd/tests/subpagetest.c
> +++ b/drivers/mtd/tests/subpagetest.c
> @@ -102,7 +102,7 @@ static int write_eraseblock2(int ebnum)
>  		if (unlikely(err || written != subpgsize * k)) {
>  			pr_err("error: write failed at %#llx\n",
>  			       (long long)addr);
> -			if (written != subpgsize) {
> +			if (written != subpgsize * k) {
>  				pr_err("  write size: %#x\n",
>  				       subpgsize * k);
>  				pr_err("  written: %#08zx\n",




More information about the linux-mtd mailing list