[PATCH] mtd: nand: atmel: Fix EDO mode check

Boris Brezillon boris.brezillon at free-electrons.com
Mon Jul 31 09:28:13 PDT 2017


On Mon, 31 Jul 2017 10:32:21 +0200
Boris Brezillon <boris.brezillon at free-electrons.com> wrote:

> EDO mode should be used when tRC is less than 30ns, but timings are
> expressed in picoseconds in the nand_sdr_timings struct.

Applied to nand/fixes.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> Fixes: f9ce2eddf176 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
> Reported-by: Alexander Dahl <ada at thorsis.com>
> ---
>  drivers/mtd/nand/atmel/nand-controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index d922a88e407f..2c8baa0c2c4e 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -1201,7 +1201,7 @@ static int atmel_smc_nand_prepare_smcconf(struct atmel_nand *nand,
>  	 * tRC < 30ns implies EDO mode. This controller does not support this
>  	 * mode.
>  	 */
> -	if (conf->timings.sdr.tRC_min < 30)
> +	if (conf->timings.sdr.tRC_min < 30000)
>  		return -ENOTSUPP;
>  
>  	atmel_smc_cs_conf_init(smcconf);




More information about the linux-mtd mailing list