[PATCH] mtd: mtdswap: remove unused variables 'dev' and 'gd'

Brian Norris computersforpeace at gmail.com
Tue Jul 25 10:03:23 PDT 2017


On Mon, Jul 24, 2017 at 05:05:24PM -0700, Brian Norris wrote:
> This was changed recently (commit e8e3edb95ce6 ("mtd: create per-device
> and module-scope debugfs entries")) and some compilers are complaining:
> 
>    drivers//mtd/mtdswap.c: In function 'mtdswap_add_debugfs':
> >> drivers//mtd/mtdswap.c:1317: warning: unused variable 'dev'
> 
> And once we kill 'dev', 'gd' is also unused.
> 
> Cc: Mario J. Rugiero <mrugiero at gmail.com>
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>

Arnd sent the same thing. Applied this one to l2-mtd.git.

> ---
>  drivers/mtd/mtdswap.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
> index 6b17932fe557..7d9080e33865 100644
> --- a/drivers/mtd/mtdswap.c
> +++ b/drivers/mtd/mtdswap.c
> @@ -1313,9 +1313,6 @@ static const struct file_operations mtdswap_fops = {
>  
>  static int mtdswap_add_debugfs(struct mtdswap_dev *d)
>  {
> -	struct gendisk *gd = d->mbd_dev->disk;
> -	struct device *dev = disk_to_dev(gd);
> -
>  	struct dentry *root = d->mtd->dbg.dfs_dir;
>  	struct dentry *dent;
>  
> -- 
> 2.14.0.rc0.284.gd933b75aa4-goog
> 



More information about the linux-mtd mailing list