UBI/UBIFS corruptions during random power-cuts
Bhuvanchandra DV
bhuvanchandra.dv at toradex.com
Tue Jan 24 22:29:42 PST 2017
On 01/19/2017 02:38 PM, Richard Weinberger wrote:
> Bhuvan,
>
> Am 19.01.2017 um 06:36 schrieb Bhuvanchandra DV:
>> Hi Richard,
>>
>> On 01/18/2017 01:28 PM, Richard Weinberger wrote:
>>
>>> Am 18.01.2017 um 06:11 schrieb Bhuvanchandra DV:
>>>>> Also apply this patch:
>>>>> http://lists.infradead.org/pipermail/linux-mtd/2017-January/071264.html
>>>> Along with this patch there are no corruptions occurred so far, power-cut tests are running fine
>>>> since few days. Will update if any issues are observed.
>>> Good to know. :-)
>> Unfortunately today in one of the test setup UBIFS got corrupted, this time the stack trace is with
>> 'ubifs_get_pnode'.
>>
>> ...
>> [ 3.885175] UBIFS error (ubi0:2 pid 1): ubifs_get_pnode.part.4: error -22 reading pnode at 8:28985
>> [ 3.894717] (pid 1) dumping pnode:
>> [ 3.898540] address c3234680 parent c3234600 cnext 0
>> [ 3.903749] flags 0 iip 3 level 0 num 0
>> [ 3.907973] 0: free 51200 dirty 131032 flags 1 lnum 0
>> [ 3.913258] 1: free 0 dirty 118032 flags 34 lnum 0
>> [ 3.918469] 2: free 92160 dirty 22752 flags 34 lnum 0
>> [ 3.923755] 3: free 40960 dirty 71672 flags 34 lnum 0
>> [ 3.929205] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc4-00016-g60124f7 #11
>> [ 3.937052] Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree)
>> [ 3.943621] Backtrace:
>> [ 3.946247] [<c010c474>] (dump_backtrace) from [<c010c71c>] (show_stack+0x18/0x1c)
>> [ 3.954009] r7:00000000 r6:60000013 r5:00000000 r4:c0e29058
>> [ 3.959822] [<c010c704>] (show_stack) from [<c03fcf38>] (dump_stack+0xb4/0xe8)
>> [ 3.967250] [<c03fce84>] (dump_stack) from [<c037bc00>] (ubifs_get_pnode.part.4+0x230/0x2b0)
>> [ 3.975882] r10:c3210e00 r9:00000008 r8:00000006 r7:c3234600 r6:00000003 r5:c30dc000
>> [ 3.983883] r4:c3234680 r3:00000000
>> [ 3.987584] [<c037b9d0>] (ubifs_get_pnode.part.4) from [<c037d604>] (ubifs_lpt_lookup_dirty+0x254/0x2a8)
>> [ 3.997265] r10:00000357 r9:00013800 r8:00000006 r7:c3232b80 r6:0000034c r5:c30dc000
>> [ 4.005262] r4:00000000
>> [ 4.007915] [<c037d3b0>] (ubifs_lpt_lookup_dirty) from [<c0380a3c>] (ubifs_update_one_lp+0x40/0x150)
>> [ 4.017246] r10:00000357 r9:00013800 r8:80000001 r7:00000357 r6:c30dcc0c r5:c30dc000
>> [ 4.025249] r4:00000091 r3:00000000
>> [ 4.028948] [<c03809fc>] (ubifs_update_one_lp) from [<c036dbc8>] (ubifs_tnc_add+0x124/0x140)
>> [ 4.037578] r8:c30dc000 r7:c323c830 r6:c323c830 r5:00000006 r4:c30dc478
>> [ 4.044424] [<c036daa4>] (ubifs_tnc_add) from [<c0371814>] (ubifs_replay_journal+0xf68/0x145c)
>> [ 4.053230] r10:c30dc000 r9:00000000 r8:00200000 r7:0000006a r6:c30dcd40 r5:c30dcd24
>> [ 4.061229] r4:c321b980
>> [ 4.063899] [<c03708ac>] (ubifs_replay_journal) from [<c03662ac>] (ubifs_mount+0x13d8/0x17d8)
>> [ 4.072624] r10:c30dc008 r9:c31d7d00 r8:c30dcb48 r7:00000000 r6:c30dc000 r5:c318a000
>> [ 4.080625] r4:00000000
>> [ 4.083290] [<c0364ed4>] (ubifs_mount) from [<c022558c>] (mount_fs+0x1c/0xb0)
>> [ 4.090578] r10:00008001 r9:00000000 r8:c0248a04 r7:c0e2515c r6:c0e2515c r5:c31d7c80
>> [ 4.098580] r4:c3108b00
>> [ 4.101245] [<c0225570>] (mount_fs) from [<c0244bd4>] (vfs_kern_mount+0x5c/0x134)
>> [ 4.108912] r6:00008001 r5:c31d7c80 r4:c3108b00
>> [ 4.113675] [<c0244b78>] (vfs_kern_mount) from [<c0248a04>] (do_mount+0x150/0xc84)
>> [ 4.121428] r9:00000060 r8:c31d7300 r7:c02498e8 r6:c31d7c80 r5:00000000 r4:c0e2515c
>> [ 4.129364] [<c02488b4>] (do_mount) from [<c02498e8>] (SyS_mount+0x7c/0xa4)
>> [ 4.136471] r10:c0d00604 r9:c0d60888 r8:00008001 r7:c0bf5644 r6:00000000 r5:c31d7c80
>> [ 4.144465] r4:c31d7300
>> [ 4.147120] [<c024986c>] (SyS_mount) from [<c0d0121c>] (mount_block_root+0x10c/0x274)
>> [ 4.155135] r8:c0d60878 r7:c7d3cac0 r6:c31d6000 r5:c31d6000 r4:00008001
>> [ 4.161987] [<c0d01110>] (mount_block_root) from [<c0d01644>] (prepare_namespace+0x98/0x1d0)
>> [ 4.170616] r10:c0d00604 r9:c0d60858 r8:c0d60854 r7:c0e78000 r6:c0d60878 r5:c0d60878
>> [ 4.178616] r4:c0d60888
>> [ 4.181264] [<c0d015ac>] (prepare_namespace) from [<c0d00ec0>] (kernel_init_freeable+0x1ac/0x1f8)
>> [ 4.190327] r6:c0d73d5c r5:c0e78000 r4:00000008
>> [ 4.195086] [<c0d00d14>] (kernel_init_freeable) from [<c0979bf0>] (kernel_init+0x10/0x120)
>> [ 4.203543] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c0979be0
>> [ 4.211534] r4:00000000
>> [ 4.214185] [<c0979be0>] (kernel_init) from [<c0107ef0>] (ret_from_fork+0x14/0x24)
>> [ 4.221931] r5:c0979be0 r4:00000000
>> [ 4.227189] UBIFS error (ubi0:2 pid 1): ubifs_get_pnode.part.4: calc num: 211
>> [ 4.234585] UBIFS error (ubi0:2 pid 1): ubifs_update_one_lp: cannot update properties of LEB 855, error -22
>> ....
>>
>> Complete boot log is available here[1]
>>
>> [1] http://pastebin.com/2Sg3SQWg
> Hmm, this is something different.
> A LPT entry accounts more dirty spaces than LEB size.
>
> Can you please enable the UBIFS debugfs "chk_lprops" knob?
> Either via userspace or just set the flag in source.
>
> Please watch out of ubifs assert message. UBIFS will *not* abort.
It took me a while to reproduce the ubifs corruption again.
The log below is after booting the kernel with chk_lprops flags set
in source on a corrupted ubifs.
Is this the flag supposed to be set in source ? Please coreect me if I'm wrong.
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 1e712a364680..721468e2df35 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2778,7 +2778,7 @@ static ssize_t dfs_file_write(struct file *file, const char __user *u,
else if (dent == d->dfs_chk_orph)
d->chk_orph = val;
else if (dent == d->dfs_chk_lprops)
- d->chk_lprops = val;
+ d->chk_lprops = 1;
else if (dent == d->dfs_chk_fs)
d->chk_fs = val;
else if (dent == d->dfs_tst_rcvry)
..
Logs:
[ 3.605299] UBIFS (ubi0:2): recovery needed
[ 3.694649] hub 1-1:1.0: USB hub found
[ 3.702704] hub 1-1:1.0: 4 ports detected
[ 3.993572] UBIFS assert failed in ubifs_categorize_lprops at 417 (pid 1)
[ 4.000943] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc4-00016-g60124f748422-dirty #13
[ 4.009765] Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree)
[ 4.016333] Backtrace:
[ 4.018957] [<c010c474>] (dump_backtrace) from [<c010c71c>] (show_stack+0x18/0x1c)
[ 4.026720] r7:00000000 r6:60000013 r5:00000000 r4:c0e29058
[ 4.032530] [<c010c704>] (show_stack) from [<c03fcf18>] (dump_stack+0xb4/0xe8)
[ 4.039972] [<c03fce64>] (dump_stack) from [<c037e914>] (ubifs_categorize_lprops+0xdc/0xf0)
[ 4.048517] r10:c31eb780 r9:c31eb780 r8:00000020 r7:c3256778 r6:c30dc000 r5:c383fb74
[ 4.056517] r4:c3256778 r3:00000000
[ 4.060216] [<c037e838>] (ubifs_categorize_lprops) from [<c037b98c>] (unpack_pnode+0xb8/0xfc)
[ 4.068944] [<c037b8d4>] (unpack_pnode) from [<c037bbc0>] (ubifs_get_pnode.part.4+0x1f0/0x2b0)
[ 4.077757] r9:00000009 r8:00000004 r7:c3253c00 r6:00000002 r5:c30dc000 r4:c3256700
[ 4.085695] [<c037b9d0>] (ubifs_get_pnode.part.4) from [<c037d604>] (ubifs_lpt_lookup_dirty+0x254/0x2a8)
[ 4.095374] r10:00000336 r9:00000240 r8:00000006 r7:c3253b98 r6:0000032b r5:c30dc000
[ 4.103371] r4:00000000
[ 4.106024] [<c037d3b0>] (ubifs_lpt_lookup_dirty) from [<c0380a3c>] (ubifs_update_one_lp+0x40/0x150)
[ 4.115355] r10:00000336 r9:00000240 r8:80000001 r7:00000336 r6:c30dcc0c r5:c30dc000
[ 4.123360] r4:000000a0 r3:00000000
[ 4.127058] [<c03809fc>] (ubifs_update_one_lp) from [<c036dbc8>] (ubifs_tnc_add+0x124/0x140)
[ 4.135688] r8:c30dc000 r7:c325df00 r6:c325df00 r5:00000000 r4:c30dc478
[ 4.142533] [<c036daa4>] (ubifs_tnc_add) from [<c0371814>] (ubifs_replay_journal+0xf68/0x145c)
[ 4.151341] r10:c30dc000 r9:00000000 r8:00000000 r7:0000006a r6:c30dcd40 r5:c30dcd24
[ 4.159337] r4:c323f280
[ 4.162008] [<c03708ac>] (ubifs_replay_journal) from [<c03662ac>] (ubifs_mount+0x13d8/0x17d8)
[ 4.170733] r10:c30dc008 r9:c31eb400 r8:c30dcb48 r7:00000000 r6:c30dc000 r5:c31f4000
[ 4.178735] r4:00000000
[ 4.181401] [<c0364ed4>] (ubifs_mount) from [<c022558c>] (mount_fs+0x1c/0xb0)
[ 4.188691] r10:00008001 r9:00000000 r8:c0248a04 r7:c0e2515c r6:c0e2515c r5:c31eb380
[ 4.196689] r4:c3108d00
[ 4.199355] [<c0225570>] (mount_fs) from [<c0244bd4>] (vfs_kern_mount+0x5c/0x134)
[ 4.207022] r6:00008001 r5:c31eb380 r4:c3108d00
[ 4.211785] [<c0244b78>] (vfs_kern_mount) from [<c0248a04>] (do_mount+0x150/0xc84)
[ 4.219546] r9:00000060 r8:c31eb340 r7:c02498e8 r6:c31eb380 r5:00000000 r4:c0e2515c
[ 4.227484] [<c02488b4>] (do_mount) from [<c02498e8>] (SyS_mount+0x7c/0xa4)
[ 4.234591] r10:c0d00604 r9:c0d60888 r8:00008001 r7:c0bf5644 r6:00000000 r5:c31eb380
[ 4.242585] r4:c31eb340
[ 4.245240] [<c024986c>] (SyS_mount) from [<c0d0121c>] (mount_block_root+0x10c/0x274)
[ 4.253263] r8:c0d60878 r7:c7d3ce00 r6:c31f0000 r5:c31f0000 r4:00008001
[ 4.260113] [<c0d01110>] (mount_block_root) from [<c0d01644>] (prepare_namespace+0x98/0x1d0)
[ 4.268744] r10:c0d00604 r9:c0d60858 r8:c0d60854 r7:c0e78000 r6:c0d60878 r5:c0d60878
[ 4.276744] r4:c0d60888
[ 4.279391] [<c0d015ac>] (prepare_namespace) from [<c0d00ec0>] (kernel_init_freeable+0x1ac/0x1f8)
[ 4.288454] r6:c0d73d5c r5:c0e78000 r4:00000008
[ 4.293212] [<c0d00d14>] (kernel_init_freeable) from [<c0979bd0>] (kernel_init+0x10/0x120)
[ 4.301668] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c0979bc0
[ 4.309662] r4:00000000
[ 4.312317] [<c0979bc0>] (kernel_init) from [<c0107ef0>] (ret_from_fork+0x14/0x24)
[ 4.320066] r5:c0979bc0 r4:00000000
[ 4.325060] UBIFS error (ubi0:2 pid 1): ubifs_get_pnode.part.4: error -22 reading pnode at 9:33006
[ 4.334503] (pid 1) dumping pnode:
[ 4.338241] address c3256700 parent c3253c00 cnext 0
[ 4.343435] flags 0 iip 2 level 0 num 0
[ 4.347644] 0: free 63488 dirty 38840 flags 34 lnum 0
[ 4.352929] 1: free 0 dirty 119976 flags 34 lnum 0
[ 4.358133] 2: free 0 dirty 10912 flags 1 lnum 0
[ 4.362971] 3: free 126976 dirty 130904 flags 36 lnum 0
[ 4.368585] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc4-00016-g60124f748422-dirty #13
[ 4.377394] Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree)
[ 4.383962] Backtrace:
[ 4.386579] [<c010c474>] (dump_backtrace) from [<c010c71c>] (show_stack+0x18/0x1c)
[ 4.394341] r7:00000000 r6:60000013 r5:00000000 r4:c0e29058
[ 4.400150] [<c010c704>] (show_stack) from [<c03fcf18>] (dump_stack+0xb4/0xe8)
[ 4.407577] [<c03fce64>] (dump_stack) from [<c037bc00>] (ubifs_get_pnode.part.4+0x230/0x2b0)
[ 4.416210] r10:c31eb780 r9:00000009 r8:00000004 r7:c3253c00 r6:00000002 r5:c30dc000
[ 4.424211] r4:c3256700 r3:00000000
[ 4.427914] [<c037b9d0>] (ubifs_get_pnode.part.4) from [<c037d604>] (ubifs_lpt_lookup_dirty+0x254/0x2a8)
[ 4.437600] r10:00000336 r9:00000240 r8:00000006 r7:c3253b98 r6:0000032b r5:c30dc000
[ 4.445596] r4:00000000
[ 4.448253] [<c037d3b0>] (ubifs_lpt_lookup_dirty) from [<c0380a3c>] (ubifs_update_one_lp+0x40/0x150)
[ 4.457591] r10:00000336 r9:00000240 r8:80000001 r7:00000336 r6:c30dcc0c r5:c30dc000
[ 4.465593] r4:000000a0 r3:00000000
[ 4.469291] [<c03809fc>] (ubifs_update_one_lp) from [<c036dbc8>] (ubifs_tnc_add+0x124/0x140)
[ 4.477921] r8:c30dc000 r7:c325df00 r6:c325df00 r5:00000000 r4:c30dc478
[ 4.484767] [<c036daa4>] (ubifs_tnc_add) from [<c0371814>] (ubifs_replay_journal+0xf68/0x145c)
[ 4.493575] r10:c30dc000 r9:00000000 r8:00000000 r7:0000006a r6:c30dcd40 r5:c30dcd24
[ 4.501570] r4:c323f280
[ 4.504244] [<c03708ac>] (ubifs_replay_journal) from [<c03662ac>] (ubifs_mount+0x13d8/0x17d8)
[ 4.512967] r10:c30dc008 r9:c31eb400 r8:c30dcb48 r7:00000000 r6:c30dc000 r5:c31f4000
[ 4.520967] r4:00000000
[ 4.523633] [<c0364ed4>] (ubifs_mount) from [<c022558c>] (mount_fs+0x1c/0xb0)
[ 4.530924] r10:00008001 r9:00000000 r8:c0248a04 r7:c0e2515c r6:c0e2515c r5:c31eb380
[ 4.538924] r4:c3108d00
[ 4.541587] [<c0225570>] (mount_fs) from [<c0244bd4>] (vfs_kern_mount+0x5c/0x134)
[ 4.549256] r6:00008001 r5:c31eb380 r4:c3108d00
[ 4.554013] [<c0244b78>] (vfs_kern_mount) from [<c0248a04>] (do_mount+0x150/0xc84)
[ 4.561772] r9:00000060 r8:c31eb340 r7:c02498e8 r6:c31eb380 r5:00000000 r4:c0e2515c
[ 4.569706] [<c02488b4>] (do_mount) from [<c02498e8>] (SyS_mount+0x7c/0xa4)
[ 4.576816] r10:c0d00604 r9:c0d60888 r8:00008001 r7:c0bf5644 r6:00000000 r5:c31eb380
[ 4.584817] r4:c31eb340
[ 4.587471] [<c024986c>] (SyS_mount) from [<c0d0121c>] (mount_block_root+0x10c/0x274)
[ 4.595487] r8:c0d60878 r7:c7d3ce00 r6:c31f0000 r5:c31f0000 r4:00008001
[ 4.602337] [<c0d01110>] (mount_block_root) from [<c0d01644>] (prepare_namespace+0x98/0x1d0)
[ 4.610968] r10:c0d00604 r9:c0d60858 r8:c0d60854 r7:c0e78000 r6:c0d60878 r5:c0d60878
[ 4.618969] r4:c0d60888
[ 4.621615] [<c0d015ac>] (prepare_namespace) from [<c0d00ec0>] (kernel_init_freeable+0x1ac/0x1f8)
[ 4.630680] r6:c0d73d5c r5:c0e78000 r4:00000008
[ 4.635435] [<c0d00d14>] (kernel_init_freeable) from [<c0979bd0>] (kernel_init+0x10/0x120)
[ 4.643894] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c0979bc0
[ 4.651887] r4:00000000
[ 4.654548] [<c0979bc0>] (kernel_init) from [<c0107ef0>] (ret_from_fork+0x14/0x24)
[ 4.662293] r5:c0979bc0 r4:00000000
[ 4.666405] UBIFS error (ubi0:2 pid 1): ubifs_get_pnode.part.4: calc num: 202
[ 4.673985] UBIFS error (ubi0:2 pid 1): ubifs_update_one_lp: cannot update properties of LEB 822, error -22
[ 4.697926] List of all partitions:
....
--
Bhuvan
>
> Thanks,
> //richard
More information about the linux-mtd
mailing list