[PATCH] mtd: aspeed: fix compile warning in aspeed_smc_read_from_ahb()

Cyrille Pitchen cyrille.pitchen at atmel.com
Fri Jan 20 05:11:57 PST 2017


Le 19/01/2017 à 18:21, Marek Vasut a écrit :
> On 01/19/2017 10:13 AM, Cédric Le Goater wrote:
>> The first argument of ioread32_rep() and ioread8_rep is not
>> const. Change aspeed_smc_read_from_ahb() prototype to fix compile
>> warning :
>>
>>    drivers/mtd/spi-nor/aspeed-smc.c: In function 'aspeed_smc_read_from_ahb':
>>    drivers/mtd/spi-nor/aspeed-smc.c:212:16: warning: passing argument 1 of 'ioread32_rep' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>>       ioread32_rep(src, buf, len >> 2);
>>
>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> 
> In this case it's IMO OK:
> 
> Reviewed-by: Marek Vasut <marek.vasut at gmail.com>
>
Applied to git://github.com/spi-nor/linux.git

Thanks!

>> ---
>>  drivers/mtd/spi-nor/aspeed-smc.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
>> index 6bb4c7d1788c..7c86099450be 100644
>> --- a/drivers/mtd/spi-nor/aspeed-smc.c
>> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
>> @@ -222,8 +222,7 @@ struct aspeed_smc_controller {
>>   * the memory buffer pointer and count via explicit code. The final updates
>>   * to len are optimistically suppressed.
>>   */
>> -static int aspeed_smc_read_from_ahb(void *buf, const void __iomem *src,
>> -				    size_t len)
>> +static int aspeed_smc_read_from_ahb(void *buf, void __iomem *src, size_t len)
>>  {
>>  	size_t offset = 0;
>>  
>>
> 
> 




More information about the linux-mtd mailing list