[PATCH] mtd: spi-nor: don't claim mr25h40 to be JEDEC compatible

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Jan 13 02:02:44 PST 2017


On Fri, Jan 13, 2017 at 10:35:09AM +0100, Uwe Kleine-König wrote:
> Commit edd0c8f4932d ("mtd: spi-nor: Add support for mr25h40") made it
> possible to use a mr25h40 by writing
> 
> 	compatible = "mr25h40", "jedec,spi-nor";
> 
> in a device tree. This chip however isn't JEDEC compatible however, so
> change the chip string and add a compatible entry to bless
> 
> 	compatible = "mr25h40-nonjedec";
> 
> as the right way.
> 
> Fixes: edd0c8f4932d ("mtd: spi-nor: Add support for mr25h40")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---

I intended to write a note here, but sent out the mail before :w :-|

I wrote:

I wonder a bit about the "-nonjedec" suffix and only added it for
consistency. AFAICT all mr25h40 don't support JEDEC, so "-nonjedec"
doesn't really qualify as hardware description. Thoughts?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-mtd mailing list