[PATCH] mtd: nand: lpc32xx: fix invalid error handling of a requested irq

Vladimir Zapolskiy vz at mleia.com
Tue Jan 3 02:16:26 PST 2017


Hi Boris,

On 01/03/2017 11:12 AM, Boris Brezillon wrote:
> Hi Vladimir
> 
> On Mon,  5 Dec 2016 03:47:10 +0200
> Vladimir Zapolskiy <vz at mleia.com> wrote:
> 
>> Semantics of NR_IRQS is different on machines with SPARSE_IRQ option
>> disabled or enabled, in the latter case IRQs are allocated starting
>> at least from the value specified by NR_IRQS and going upwards, so
>> the check of (irq >= NR_IRQ) to decide about an error code returned by
>> platform_get_irq() is completely invalid, don't attempt to overrule
>> irq subsystem in the driver.
>>
>> The change fixes LPC32xx NAND MLC driver initialization on boot.
> 
> Do you need to backport this fix to stable releases? If that's the
> case, I'll add the Cc: stable tag when applying.

that will be great if you can add

Cc: stable at kernel.org # v4.7+

Please feel free to add also the tag

Fixes: 8cb17b5ed017 ("irqchip: Add LPC32xx interrupt controller driver")

--
With best wishes,
Vladimir




More information about the linux-mtd mailing list