[PATCH v2 02/16] device-dax: fix cdev leak

Dan Williams dan.j.williams at intel.com
Sun Feb 26 10:22:36 PST 2017


On Sat, Feb 25, 2017 at 10:38 PM, Logan Gunthorpe <logang at deltatee.com> wrote:
> From: Dan Williams <dan.j.williams at intel.com>
>
> If device_add() fails, cleanup the cdev. Otherwise, we leak a kobj_map()
> with a stale device number.
>
> As Jason points out, there is a small possibility that userspace has
> opened and mapped the device in the time between cdev_add() and the
> device_add() failure. We need a new kill_dax_dev() helper to invalidate
> any established mappings.
>
> Fixes: ba09c01d2fa8 ("dax: convert to the cdev api")
> Cc: <stable at vger.kernel.org>
> Cc: Logan Gunthorpe <logang at deltatee.com>
> Reported-by: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
> Signed-off-by: Dan Williams <dan.j.williams at intel.com>

Since you are forwarding this patch you should add

"Signed-off-by: Logan Gunthorpe <logang at deltatee.com>"



More information about the linux-mtd mailing list