[GIT PULL] mtd: spi-nor: Changes for 4.11

Brian Norris computersforpeace at gmail.com
Thu Feb 9 18:46:24 PST 2017


On Wed, Feb 08, 2017 at 11:09:39AM -0800, Brian Norris wrote:
> On Wed, Feb 08, 2017 at 11:36:10AM +0100, Cyrille Pitchen wrote:
> > Le 08/02/2017 à 06:52, Heiner Kallweit a écrit :
> > > Am 08.02.2017 um 02:09 schrieb Marek Vasut:
> > >> On 02/07/2017 04:31 PM, Cyrille Pitchen wrote:
> > [...]
> > >>> Heiner Kallweit (1):
> > >>>       mtd: m25p80: consider max message size in m25p80_read
> > >>
> > >> I cannot say I'm super-happy about this particular patch, still ...
> > >>
> > > W/o it at least the fsl-espi driver is broken for transfers >= 64kB.
> > > 
[...]

> One thing I do object to: why is this change marked for stable? It's not
> our fault you broke your duct-taped-together SPI driver in 4.9. I don't
> think backporting features is the way to satisfy the -stable
> requirements. Maybe some reverts would be the right way...

OK, I've reviewed the rest of the pull request as well as I care for.
I still have this one objection: I don't think this belongs in -stable.

Am I crazy? Or else Cyrille, can you remove the stable tag and resend?
Or I can go rewrite your history for you and do this...

Brian

P.S. Also, this stuck out at me in the diffs, and checkpatch complained
too. Not a real big deal:

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each
line
#42: FILE: drivers/mtd/spi-nor/spi-nor.c:83:
+					 * ATMEL flashes)
+					*/

total: 0 errors, 1 warnings, 264 lines checked




More information about the linux-mtd mailing list