[PATCH] Fix OOB_READ bug where hardware FIFO is not drained completely. Fix potential bug for non-ECC operations.

Sean Nyekjær sean.nyekjaer at prevas.dk
Sun Dec 17 23:44:36 PST 2017


Hi Boris
>>
>> Can you try with the below patch and see if it fixes the timeout issue?
>>
>> --->8---
>> diff --git a/drivers/mtd/nand/pxa3xx_nand.c 
>> b/drivers/mtd/nand/pxa3xx_nand.c
>> index 021374fe59dc..d1979c7dbe7e 100644
>> --- a/drivers/mtd/nand/pxa3xx_nand.c
>> +++ b/drivers/mtd/nand/pxa3xx_nand.c
>> @@ -961,6 +961,7 @@ static void prepare_start_command(struct 
>> pxa3xx_nand_info *info, int command)
>>            switch (command) {
>>          case NAND_CMD_READ0:
>> +       case NAND_CMD_READOOB:
>>          case NAND_CMD_PAGEPROG:
>>                  info->use_ecc = 1;
>>                  break;
> This fixes the timeout issue :-) Also without bbt...
>
> root at output-module:~# nanddump -oa /dev/mtd1
> ECC failed: 0
> ECC corrected: 0
> Number of bad blocks: 0
> Number of bbt blocks: 8
> Block size 131072, page size 2048, OOB size 64
> Dumping data starting at 0x00000000 and ending at 0x0ff00000...
> UBIXSUBI
>

Is this considered a valid patch for our 4.14 LTS kernel, pxa3xx driver?
Or is it only masking some other problems?

/Sean



More information about the linux-mtd mailing list