[PATCH v2] mtd: nand: add ->exec_op() implementation

Boris Brezillon boris.brezillon at free-electrons.com
Mon Dec 11 12:52:55 PST 2017


Hi Miquel,

On Mon, 11 Dec 2017 21:17:50 +0100
Miquel RAYNAL <miquel.raynal at free-electrons.com> wrote:

> Hello Antoine,
> 
> On Fri, 8 Dec 2017 08:54:50 +0100
> Antoine Tenart <antoine.tenart at free-electrons.com> wrote:
> 
> > Hi Miquel,
> > 
> > Be careful when defining macros: avoid to name your arguments with a
> > value used in the macro that is not meant to be replaced.  
> 
> That is right, it could have failed the macro.

Fixed the macro.
Also reworded a few comments in the code, and the commit log. I also
moved some prototype changes that belong in patch "mtd: nand: provide
several helpers to do common NAND operations".

The resulting patch is applied to the nand/next branch.

Thanks a lot for the effort you've put in this new infrastructure, I
really like the result. It's not perfect and people will probably have
to extend the existing parser to support their controller, but it
clearly goes in the right direction.

I really hope that more controllers will be converted to this new
interface in a near future (you already converted 2 of them).

Regards,

Boris



More information about the linux-mtd mailing list