[PATCH 0/2 v2] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths

Christophe JAILLET christophe.jaillet at wanadoo.fr
Fri Dec 8 23:24:03 PST 2017


The first patch converts 's3c_onenand_probe()' to devm_ functions.
This fixes a leak in one path (line 872).
This also free_irq which was not handled at all. (I hope I'm correct :) )

The 2nd patch is about an un-handled error code which looks spurious.
Not sure if I'm right.


While compile-testing it, I had to tweak the code because I don't have any
cross-compiler.
I commented the line "#include <asm/mach/flash.h>" and the compilation
succeeded. So maybe, this include is also useless.
I've left it as-is, though.


Theses patches have been compile-tested-only.


Christophe JAILLET (2):
  mtd: onenand: samsung: use devm_ function to simplify code and fix
    some leaks
  mtd: onenand: samsung: return an error if
    'mtd_device_parse_register()' fails

 drivers/mtd/onenand/samsung.c | 169 +++++++++---------------------------------
 1 file changed, 34 insertions(+), 135 deletions(-)

-- 
2.14.1




More information about the linux-mtd mailing list