[PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash
Z.q. Hou
zhiqiang.hou at nxp.com
Tue Dec 5 18:17:36 PST 2017
Hi Cyrille,
Thanks a lot for your comments!
> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen at wedev4u.fr]
> Sent: 2017年12月6日 4:41
> To: Z.q. Hou <zhiqiang.hou at nxp.com>; linux-mtd at lists.infradead.org;
> linux-kernel at vger.kernel.org; computersforpeace at gmail.com;
> dwmw2 at infradead.org; boris.brezillon at free-electrons.com;
> marek.vasut at gmail.com; richard at nod.at
> Subject: Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when
> stop using the flash
>
> Hi Hou,
>
> Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit :
> > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >
> > To be compatible with legacy device, reset the addressing mode to the
> > default mode. Such as Freescale eSPI boot, it copies the images from
> > SPI flash without firing a reset signal previously, so the reboot
> > command will fail without reseting the addressing mode of SPI flash.
> >
>
> You should put this in one of the commit messages so it explains which issue is
> fixed by your patches.
Agree with you, and will do it in next version.
>
> Otherwise, your series looks good to me :)
>
> Best regards,
>
> Cyrille
>
> > Hou Zhiqiang (2):
> > mtd: spi-nor: add an API to restore the status of SPI flash chip
> > mtd: m25p80: restore the status of SPI flash when stop using it
> >
> > Documentation/mtd/spi-nor.txt | 3 +++ drivers/mtd/devices/m25p80.c
> > | 9 +++++++++ drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++
> > include/linux/mtd/spi-nor.h | 6 ++++++
> > 4 files changed, 28 insertions(+)
> >
Thanks,
Zhiqiang
More information about the linux-mtd
mailing list