[PATCH v5] mtd: nand: tango: import driver for tango chips

[Artem Bityutskiy]

On Tue, 2016-09-20 at 09:24 +0200, Boris Brezillon wrote:
> > >> +  writel_relaxed(chip->timing1,   nfc->reg_base + NFC_TIMING1);
> > >> +  writel_relaxed(chip->timing2,   nfc->reg_base + NFC_TIMING2);
> > >> +  writel_relaxed(chip->xfer_cfg,  nfc->reg_base + NFC_XFER_CFG);
> > >> +  writel_relaxed(chip->pkt_0_cfg, nfc->reg_base + NFC_PKT_0_CFG);
> > >> +  writel_relaxed(chip->pkt_n_cfg, nfc->reg_base + NFC_PKT_N_CFG);
> > >> +  writel_relaxed(chip->bb_cfg,    nfc->reg_base + NFC_BB_CFG);  
> > > 
> > > Nit: can you avoid these weird alignments. Use a single space after the
> > > comma.  
> > 
> > I was trying to highlight the fact that all these writes are
> > within the reg_base area. I'll do as you ask, since you are
> > the gatekeeper.
> 
> Is that really less clear without the tabs?

Visually the aligned stuff looks nicer, and some kernel maintainers
prefer this style. Other maintainers avoid it because it causes more
churn. Indeed, imaging you need to add another field with longer name,
or one of the existing fields is renamed - then you need to re-align,
your patches become larger.

So my suggestion is to just follow maintainers' preferences.