[PATCH 1/9] mtd: nand: Create a NAND reset function

Boris Brezillon boris.brezillon at free-electrons.com
Fri Sep 9 05:26:35 PDT 2016


On Fri, 9 Sep 2016 09:15:52 -0300
Fabio Estevam <festevam at gmail.com> wrote:

> Hi Sascha,
> 
> On Fri, Sep 9, 2016 at 9:05 AM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> >  /**
> > + * nand_reset - Reset and initialize a NAND device
> > + * @chip: The NAND chip
> > + *
> > + * Returns 0 for success or negative error code otherwise
> > + */
> > +int nand_reset(struct nand_chip *chip)
> > +{
> > +       chip->cmdfunc(&chip->mtd, NAND_CMD_RESET, -1, -1);
> > +
> > +       return 0;  
> 
> It always return 0 here, so the comment and code do not match.

Not sure this is a big problem, because the function is updated in
patch 6 and after that it can return an error.



More information about the linux-mtd mailing list