[PATCH] ubifs: compress lines for immediate return
Heiko Schocher
hs at denx.de
Sun Sep 4 23:35:37 PDT 2016
Hello Richard,
Am 05.09.2016 um 08:28 schrieb Richard Weinberger:
> Heiko,
>
> On 05.09.2016 06:59, Heiko Schocher wrote:
>> fix the following code:
>>
>> -ret = expression;
>> -if (ret)
>> - return ret;
>> -return 0;
>> +return expression;
>
> "Fix"? ;-)
> What was broken?
Ok, fix is to hard spoken ... nothing broken, sorry for confusing!
> I agree that we can write the expression in a different way, but is it really worth it?
I think yes ...
> Is this part of a tree-wide cleanup?
Yes, and I thought it is worth to change this part in linux too.
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
More information about the linux-mtd
mailing list