[PATCH] mtd: nand: pxa3xx_nand: write exactly one message on probe failure

Robert Jarzmik robert.jarzmik at free.fr
Sat Oct 29 12:59:18 PDT 2016


Marek Vasut <marek.vasut at gmail.com> writes:

> On 10/28/2016 10:04 AM, Boris Brezillon wrote:
>> On Mon, 19 Sep 2016 11:21:18 +0200
>> Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:
>> 
>>> For some error paths alloc_nand_resource() emitted an error message, for
>>> others it didn't. Make it consistently print a message including the
>>> error code where it's not constant and drop the hardly helpful
>>> additional message printed by the caller of alloc_nand_resource.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>> 
>> It looks good to me. Ezequiel, Robert, any objection to this patch? If
>> not, can I have your Acked/Reviewed-by ?
Hi,

Actually I was wondering if my mail system is utterly broken ... This is the
first mail I receive, while it seems to me I was in the recipients in the former
ones ...

You can take my Reviewed-by, at least from:
	https://patchwork.ozlabs.org/patch/671644/

As a side note, normally for pxa architecture we use a printk format to display
the return value as :
   pr_something("XXXX :%d\n", ret)

As pxa3xx_nand is shared with other architectures this will be Boris/Ezequiel's
call.

Cheers.

--
Robert



More information about the linux-mtd mailing list