[PATCH] mtd: nand: Fix data interface configuration logic

Marc Gonzalez marc_gonzalez at sigmadesigns.com
Tue Oct 25 05:29:55 PDT 2016


On 24/10/2016 16:46, Boris Brezillon wrote:

> When changing from one data interface setting to another, one has to
> ensure a specific sequence which is described in the ONFI spec.
> 
> One of these constraints is that the CE line has go high after a reset
> before a command can be sent with the new data interface setting, which
> is not guaranteed by the current implementation.
> 
> Rework the nand_reset() function and all the call sites to make sure the
> CE line is asserted and released when required.
> 
> Also make sure to actually apply the new data interface setting on the
> first die.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> Fixes: d8e725dd8311 ("mtd: nand: automate NAND timings selection")
> ---
>  drivers/mtd/nand/nand_base.c | 60 +++++++++++++++++++++++++++++++-------------
>  include/linux/mtd/nand.h     |  2 +-
>  2 files changed, 43 insertions(+), 19 deletions(-)

Tested-by: Marc Gonzalez <marc_gonzalez at sigmadesigns.com>

Regards.




More information about the linux-mtd mailing list