[PATCH] ubifs: implement POSIX Access Control Lists (ACLs)

Andreas Gruenbacher agruenba at redhat.com
Wed Oct 19 08:05:19 PDT 2016


On Wed, Oct 19, 2016 at 4:51 PM, Josef Bacik <jbacik at fb.com> wrote:
> Looks right to me, we call this during inode creation, so if there is no ACL
> to set then we cache no acl so we don't waste the lookup later.

This is when we create an new inode, so neither i_acl nor
i_default_acl should be ACL_NOT_CACHED when this function succeeds. So
either we should make sure that i_acl and i_default_acl are already
not set to ACL_NOT_CACHED anymore when entering this function, or
cache_no_acl should be called unconditionally before setting the
actual ACLs.

Thanks,
Andreas



More information about the linux-mtd mailing list