[PATCH v2 2/3] mtd: spi-nor: Implement die erase command logic
marcin.krzeminski at nokia.com
marcin.krzeminski at nokia.com
Fri Nov 18 02:42:48 PST 2016
From: Marcin Krzeminski <marcin.krzeminski at nokia.com>
This commit implements die erase logic.
Sector at a time procedure is moved to function,
then erase algorithm will try to use die erase cmd
if size and address cover one or more dies.
Signed-off-by: Marcin Krzeminski <marcin.krzeminski at nokia.com>
---
drivers/mtd/spi-nor/spi-nor.c | 88 +++++++++++++++++++++++++++++++++++++------
1 file changed, 77 insertions(+), 11 deletions(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 9b8656e..5fc809e 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -369,6 +369,29 @@ static int spi_nor_erase_sector(struct spi_nor *nor, u32 addr)
return nor->write_reg(nor, nor->erase_opcode, buf, nor->addr_width);
}
+static inline int spi_nor_sector_at_time_erase(struct mtd_info *mtd, u32 addr, u32 len)
+{
+ struct spi_nor *nor = mtd_to_spi_nor(mtd);
+ int ret = 0;
+
+ while (len) {
+ write_enable(nor);
+
+ ret = spi_nor_erase_sector(nor, addr);
+ if (ret)
+ return ret;
+
+ addr += mtd->erasesize;
+ len -= mtd->erasesize;
+
+ ret = spi_nor_wait_till_ready(nor);
+ if (ret)
+ return ret;
+ }
+
+ return ret;
+}
+
/*
* Erase an address range on the nor chip. The address range may extend
* one or more erase sectors. Return an error is there is a problem erasing.
@@ -376,9 +399,10 @@ static int spi_nor_erase_sector(struct spi_nor *nor, u32 addr)
static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
{
struct spi_nor *nor = mtd_to_spi_nor(mtd);
- u32 addr, len;
+ u32 addr, len, die_no, die_size;
uint32_t rem;
int ret;
+ unsigned long timeout;
dev_dbg(nor->dev, "at 0x%llx, len %lld\n", (long long)instr->addr,
(long long)instr->len);
@@ -395,7 +419,7 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
return ret;
/* whole-chip erase? */
- if (len == mtd->size) {
+ if (len == mtd->size && !(nor->flags & SNOR_F_DIE_ERASE)) {
unsigned long timeout;
write_enable(nor);
@@ -425,17 +449,59 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
/* "sector"-at-a-time erase */
} else {
- while (len) {
- write_enable(nor);
-
- ret = spi_nor_erase_sector(nor, addr);
- if (ret)
+ if (nor->die_cnt && (nor->flags & SNOR_F_DIE_ERASE)) {
+ die_size = div_u64_rem(mtd->size, nor->die_cnt, &rem);
+ if (rem) {
+ ret = -EINVAL;
goto erase_err;
+ }
- addr += mtd->erasesize;
- len -= mtd->erasesize;
-
- ret = spi_nor_wait_till_ready(nor);
+ while (len) {
+ die_no = div_u64_rem(addr, die_size, &rem);
+
+ /* Check if address is aligned to die begin*/
+ if (!rem) {
+ /* die erase? */
+ if (len >= die_size) {
+ ret = spi_nor_die_erase(nor, addr);
+ if (ret)
+ goto erase_err;
+
+ len -= die_size;
+ addr += die_size;
+
+ timeout = max(CHIP_ERASE_2MB_READY_WAIT_JIFFIES,
+ CHIP_ERASE_2MB_READY_WAIT_JIFFIES *
+ (unsigned long)(die_size / SZ_2M));
+ ret = spi_nor_wait_till_ready_with_timeout(nor, timeout);
+ if (ret)
+ goto erase_err;
+ } else {
+ ret = spi_nor_sector_at_time_erase(mtd, addr, len);
+ if (ret)
+ goto erase_err;
+ len = 0;
+ }
+ } else {
+ /* check if end address cover at least one die */
+ if (div64_ul(addr + len, die_size) > ++die_no) {
+ /* align to next die */
+ rem = die_size - rem;
+ ret = spi_nor_sector_at_time_erase(mtd, addr, rem);
+ if (ret)
+ goto erase_err;
+ len -= rem;
+ addr += rem;
+ } else {
+ ret = spi_nor_sector_at_time_erase(mtd, addr, len);
+ if (ret)
+ goto erase_err;
+ len = 0;
+ }
+ }
+ }
+ } else {
+ ret = spi_nor_sector_at_time_erase(mtd, addr, len);
if (ret)
goto erase_err;
}
--
2.7.4
More information about the linux-mtd
mailing list