[PATCH v8] mtd: nand: add tango NAND flash controller support
Mason
slash.tmp at free.fr
Fri Nov 11 08:01:52 PST 2016
On 06/11/2016 23:58, Boris Brezillon wrote:
> Applied after fixing a few coding style issues to make checkpatch happy.
First of all, I want to thank you for all the help you provided
along the way.
I have to admit that I'm a bit frustrated by some of the changes you made
to the patch.
Specifically, changing
from: if (ptr_expr == NULL)
to: if (!ptr_expr)
I dislike the second form, because it "hides" what is being tested.
I've even seen people use !count to mean count == 0, and I find that
very unintuitive.
I also have a hard time discerning a '!' after a '('
The other change is the chip->options initialization. I thought
you said on IRC I could keep my preferred formatting.
In the end, these are tiny issues in the grand scheme of things,
but it was important for me to point them out.
Regards.
More information about the linux-mtd
mailing list