[PATCH v2 1/2] mtd: spi-nor: add an alternative method to support memory >16MiB

kbuild test robot lkp at intel.com
Tue Mar 22 09:57:00 PDT 2016


Hi Cyrille,

[auto build test ERROR on mtd/master]
[also build test ERROR on v4.5 next-20160322]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Cyrille-Pitchen/mtd-spi-nor-add-an-alternative-method-to-support-memory-16MiB/20160322-231624
base:   git://git.infradead.org/linux-mtd.git master
config: arm-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

>> drivers/mtd/devices/st_spi_fsm.c:511:26: error: 'SPINOR_OP_READ4_1_1_4' undeclared here (not in a function)
     {FLASH_FLAG_READ_1_1_4, SPINOR_OP_READ4_1_1_4, 0, 1, 4, 0x00, 0, 8},
                             ^
>> drivers/mtd/devices/st_spi_fsm.c:513:26: error: 'SPINOR_OP_READ4_1_1_2' undeclared here (not in a function)
     {FLASH_FLAG_READ_1_1_2, SPINOR_OP_READ4_1_1_2, 0, 1, 2, 0x00, 0, 8},
                             ^
>> drivers/mtd/devices/st_spi_fsm.c:514:25: error: 'SPINOR_OP_READ4_FAST' undeclared here (not in a function)
     {FLASH_FLAG_READ_FAST, SPINOR_OP_READ4_FAST, 0, 1, 1, 0x00, 0, 8},
                            ^
>> drivers/mtd/devices/st_spi_fsm.c:515:26: error: 'SPINOR_OP_READ4' undeclared here (not in a function)
     {FLASH_FLAG_READ_WRITE, SPINOR_OP_READ4, 0, 1, 1, 0x00, 0, 0},
                             ^
>> drivers/mtd/devices/st_spi_fsm.c:557:2: error: initializer element is not constant
     {FLASH_FLAG_READ_1_1_4,  SPINOR_OP_READ4_1_1_4,  0, 1, 4, 0x00, 0, 8},
     ^
   drivers/mtd/devices/st_spi_fsm.c:557:2: error: (near initialization for 'stfsm_s25fl_read4_configs[1].cmd')
   drivers/mtd/devices/st_spi_fsm.c:559:2: error: initializer element is not constant
     {FLASH_FLAG_READ_1_1_2,  SPINOR_OP_READ4_1_1_2,  0, 1, 2, 0x00, 0, 8},
     ^
   drivers/mtd/devices/st_spi_fsm.c:559:2: error: (near initialization for 'stfsm_s25fl_read4_configs[3].cmd')
   drivers/mtd/devices/st_spi_fsm.c:560:2: error: initializer element is not constant
     {FLASH_FLAG_READ_FAST,   SPINOR_OP_READ4_FAST,   0, 1, 1, 0x00, 0, 8},
     ^
   drivers/mtd/devices/st_spi_fsm.c:560:2: error: (near initialization for 'stfsm_s25fl_read4_configs[4].cmd')
   drivers/mtd/devices/st_spi_fsm.c:561:2: error: initializer element is not constant
     {FLASH_FLAG_READ_WRITE,  SPINOR_OP_READ4,        0, 1, 1, 0x00, 0, 0},
     ^
   drivers/mtd/devices/st_spi_fsm.c:561:2: error: (near initialization for 'stfsm_s25fl_read4_configs[5].cmd')

vim +/SPINOR_OP_READ4_1_1_4 +511 drivers/mtd/devices/st_spi_fsm.c

e85a6196 Lee Jones    2014-03-20  505   *	- use special 4-byte address READ commands (reduces overheads, and
e85a6196 Lee Jones    2014-03-20  506   *        reduces risk of hitting watchdog reset issues).
e85a6196 Lee Jones    2014-03-20  507   *	- 'FAST' variants configured for 8 dummy cycles (see note above.)
e85a6196 Lee Jones    2014-03-20  508   */
e85a6196 Lee Jones    2014-03-20  509  static struct seq_rw_config n25q_read4_configs[] = {
92d3af9a Brian Norris 2014-04-08  510  	{FLASH_FLAG_READ_1_4_4, SPINOR_OP_READ4_1_4_4,	0, 4, 4, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08 @511  	{FLASH_FLAG_READ_1_1_4, SPINOR_OP_READ4_1_1_4,	0, 1, 4, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08  512  	{FLASH_FLAG_READ_1_2_2, SPINOR_OP_READ4_1_2_2,	0, 2, 2, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08 @513  	{FLASH_FLAG_READ_1_1_2, SPINOR_OP_READ4_1_1_2,	0, 1, 2, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08 @514  	{FLASH_FLAG_READ_FAST,	SPINOR_OP_READ4_FAST,	0, 1, 1, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08 @515  	{FLASH_FLAG_READ_WRITE, SPINOR_OP_READ4,	0, 1, 1, 0x00, 0, 0},
e85a6196 Lee Jones    2014-03-20  516  	{0x00,			0,			0, 0, 0, 0x00, 0, 0},
e85a6196 Lee Jones    2014-03-20  517  };
e85a6196 Lee Jones    2014-03-20  518  
89818066 Lee Jones    2014-03-20  519  /*
89818066 Lee Jones    2014-03-20  520   * [MX25xxx] Configuration
89818066 Lee Jones    2014-03-20  521   */
89818066 Lee Jones    2014-03-20  522  #define MX25_STATUS_QE			(0x1 << 6)
89818066 Lee Jones    2014-03-20  523  
89818066 Lee Jones    2014-03-20  524  static int stfsm_mx25_en_32bit_addr_seq(struct stfsm_seq *seq)
89818066 Lee Jones    2014-03-20  525  {
89818066 Lee Jones    2014-03-20  526  	seq->seq_opc[0] = (SEQ_OPC_PADS_1 |
89818066 Lee Jones    2014-03-20  527  			   SEQ_OPC_CYCLES(8) |
6c8e1b33 Brian Norris 2014-04-08  528  			   SEQ_OPC_OPCODE(SPINOR_OP_EN4B) |
89818066 Lee Jones    2014-03-20  529  			   SEQ_OPC_CSDEASSERT);
89818066 Lee Jones    2014-03-20  530  
89818066 Lee Jones    2014-03-20  531  	seq->seq[0] = STFSM_INST_CMD1;
89818066 Lee Jones    2014-03-20  532  	seq->seq[1] = STFSM_INST_WAIT;
89818066 Lee Jones    2014-03-20  533  	seq->seq[2] = STFSM_INST_STOP;
89818066 Lee Jones    2014-03-20  534  
89818066 Lee Jones    2014-03-20  535  	seq->seq_cfg = (SEQ_CFG_PADS_1 |
89818066 Lee Jones    2014-03-20  536  			SEQ_CFG_ERASE |
89818066 Lee Jones    2014-03-20  537  			SEQ_CFG_READNOTWRITE |
89818066 Lee Jones    2014-03-20  538  			SEQ_CFG_CSDEASSERT |
89818066 Lee Jones    2014-03-20  539  			SEQ_CFG_STARTSEQ);
89818066 Lee Jones    2014-03-20  540  
89818066 Lee Jones    2014-03-20  541  	return 0;
89818066 Lee Jones    2014-03-20  542  }
89818066 Lee Jones    2014-03-20  543  
5343a123 Lee Jones    2014-03-20  544  /*
5343a123 Lee Jones    2014-03-20  545   * [S25FLxxx] Configuration
5343a123 Lee Jones    2014-03-20  546   */
5343a123 Lee Jones    2014-03-20  547  #define STFSM_S25FL_CONFIG_QE		(0x1 << 1)
5343a123 Lee Jones    2014-03-20  548  
5343a123 Lee Jones    2014-03-20  549  /*
5343a123 Lee Jones    2014-03-20  550   * S25FLxxxS devices provide three ways of supporting 32-bit addressing: Bank
5343a123 Lee Jones    2014-03-20  551   * Register, Extended Address Modes, and a 32-bit address command set.  The
5343a123 Lee Jones    2014-03-20  552   * 32-bit address command set is used here, since it avoids any problems with
5343a123 Lee Jones    2014-03-20  553   * entering a state that is incompatible with the SPIBoot Controller.
5343a123 Lee Jones    2014-03-20  554   */
5343a123 Lee Jones    2014-03-20  555  static struct seq_rw_config stfsm_s25fl_read4_configs[] = {
92d3af9a Brian Norris 2014-04-08  556  	{FLASH_FLAG_READ_1_4_4,  SPINOR_OP_READ4_1_4_4,  0, 4, 4, 0x00, 2, 4},
92d3af9a Brian Norris 2014-04-08 @557  	{FLASH_FLAG_READ_1_1_4,  SPINOR_OP_READ4_1_1_4,  0, 1, 4, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08  558  	{FLASH_FLAG_READ_1_2_2,  SPINOR_OP_READ4_1_2_2,  0, 2, 2, 0x00, 4, 0},
92d3af9a Brian Norris 2014-04-08  559  	{FLASH_FLAG_READ_1_1_2,  SPINOR_OP_READ4_1_1_2,  0, 1, 2, 0x00, 0, 8},
92d3af9a Brian Norris 2014-04-08  560  	{FLASH_FLAG_READ_FAST,   SPINOR_OP_READ4_FAST,   0, 1, 1, 0x00, 0, 8},

:::::: The code at line 511 was first introduced by commit
:::::: 92d3af9ac369faf3bd2c409cf5218510500af214 mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_*

:::::: TO: Brian Norris <computersforpeace at gmail.com>
:::::: CC: Brian Norris <computersforpeace at gmail.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/octet-stream
Size: 55437 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20160323/e73a44ea/attachment-0001.obj>


More information about the linux-mtd mailing list