[RESEND PATCH v7] mtd: spi-nor: add hisilicon spi-nor flash controller driver

Ezequiel Garcia ezequiel at vanguardiasur.com.ar
Fri Mar 4 16:35:00 PST 2016


Hi Jiancheng,

On 26 February 2016 at 05:11, Jiancheng Xue <xuejiancheng at huawei.com> wrote:
[..]
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index 0dc9275..c86d7cf 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -37,6 +37,12 @@ config SPI_FSL_QUADSPI
>           This controller does not support generic SPI. It only supports
>           SPI NOR.
>
> +config SPI_HISI_SFC
> +       tristate "Hisilicon SPI-NOR Flash Controller(SFC)"
> +       depends on ARCH_HISI || COMPILE_TEST

I believe you are missing a "depends on HAS_IOMEM".
The NXP_SPIFI driver below does the right thing in this
regard.

Otherwise, you'll get a build failure on ARCH=um.

drivers/built-in.o: In function `hisi_spi_nor_probe':
hisi-sfc.c:(.text+0x57ca5): undefined reference to `devm_ioremap_resource'
hisi-sfc.c:(.text+0x57d0e): undefined reference to `dmam_alloc_coherent'

Care to send a new one?
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar



More information about the linux-mtd mailing list