[PATCH] mtd: nand: tests: fix regression introduced in mtd_nandectest

Boris Brezillon boris.brezillon at free-electrons.com
Tue Mar 1 13:17:55 PST 2016


Hi Jorge,

On Tue,  1 Mar 2016 16:04:00 -0500
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org> wrote:

> Offending Commit: 6e94119 "mtd: nand: return consistent error codes in
> ecc.correct() implementations"
> 
> The new error code was not being handled properly in double bit error
> detection.
> 
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org>

Reviewed-by: Boris Brezillon <boris.brezillon at free-electrons.com>

Thanks,

Boris

> ---
>  drivers/mtd/tests/mtd_nandecctest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/tests/mtd_nandecctest.c b/drivers/mtd/tests/mtd_nandecctest.c
> index 7931615..88b6c81 100644
> --- a/drivers/mtd/tests/mtd_nandecctest.c
> +++ b/drivers/mtd/tests/mtd_nandecctest.c
> @@ -187,7 +187,7 @@ static int double_bit_error_detect(void *error_data, void *error_ecc,
>  	__nand_calculate_ecc(error_data, size, calc_ecc);
>  	ret = __nand_correct_data(error_data, error_ecc, calc_ecc, size);
>  
> -	return (ret == -1) ? 0 : -EINVAL;
> +	return (ret == -EBADMSG) ? 0 : -EINVAL;
>  }
>  
>  static const struct nand_ecc_test nand_ecc_test[] = {



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the linux-mtd mailing list