[PATCH 1/2] mtd: brcmnand: Add check for erased page bitflips
Kamal Dasu
kamal.dasu at broadcom.com
Wed Jun 1 10:27:20 PDT 2016
Boris,
>> I'm quite sure you can't make use of NAND_ECC_GENERIC_ERASED_CHECK
>> unless you do a substantial rewrite; brcmnand doesn't use any of the
>> nand_base ecc.read_{page,subpage} callbacks.
>>
>> > If that works as expected I will get rid of this duplication and send
>> > a revised change which shall make use of the
>> > NAND_ECC_GENERIC_ERASED_CHECK option.
>>
>> I suspect he was just suggesting calling the
>> nand_check_erased_ecc_chunk() helper instead of doing your own
>> bitmap_weight() calls.
>
> Exactly.
>
>
Ok got it. Yes I did realize that using the option is not straight
forward as far as brcmnand driver is concerned.
Thanks
Kamal
More information about the linux-mtd
mailing list