mtd: nand: omap2: check for elm_id removed

Boris Brezillon boris.brezillon at free-electrons.com
Mon Jul 4 06:01:59 PDT 2016


On Mon, 04 Jul 2016 14:51:57 +0200
Teresa Remmet <t.remmet at phytec.de> wrote:

> Hello,
> 
> with commit c9711ec5250b22fd94e9b34c17c095e001a90e66
> ("mtd: nand: omap: Clean up device tree support")
> the old "elm_id" property check has been removed. So only "ti,elm-id" is
> valid now.
> I noticed that the old property is still used by 3 boards:
> 
> git grep elm_id arch/arm/boot/dts/*
> arch/arm/boot/dts/am335x-baltos.dtsi:           elm_id = <&elm>;
> arch/arm/boot/dts/am335x-igep0033.dtsi:         elm_id = <&elm>;
> arch/arm/boot/dts/am335x-phycore-som.dtsi:              elm_id = <&elm>;
> 
> I wonder if the right way would be to patch the device trees, or to add
> the check again and to keep backward compatibility?

We should probably do both, though backward compat is usually dependent
on the platform maintainer (some accept to break DT backward compat).

Anyway, all DTs should be patched to use the new binding, so you can at
least send a patch doing that.

> 
> I may provide a patch then.
> 
> Regards,
> Teresa
> 




More information about the linux-mtd mailing list