[PATCH] mtd-utils: Add configure switches to disable jffsX or ubifs tools

David Oberhollenzer david.oberhollenzer at sigma-star.at
Thu Dec 22 01:27:36 PST 2016


On 12/22/2016 10:19 AM, Thomas Petazzoni wrote:
> If the only two correct values are "yes" or "no", then you should use
> AC_ARG_ENABLE() and not AC_ARG_WITH().
That is indeed an interesting consideration. The guides seem to be a bit
blury on the destinction on enable/disable vs with/without.

I was under the impression that one should use enable/disable for features
of a program and with/without for external dependencies or entire programs,
i.e. "features of a project".

> Indeed, using AM_CONDITIONAL() is useful to assign automake variable.
> Here, BUILD_JFFS and BUILD_UBIFS are apparently only used within the
> configure.ac, so using AM_CONDITIONAL() is useless.
Not quite. They are used in the automake file to skip building mkfs.ubifs
and the jffsx utils.


Thanks,

David




More information about the linux-mtd mailing list