[PATCH v3 3/5] mtd: aspeed: used a label property

Marek Vasut marek.vasut at gmail.com
Sun Dec 11 18:27:00 PST 2016


On 12/12/2016 12:46 AM, Joel Stanley wrote:
> On Sat, Dec 10, 2016 at 3:49 AM, Cédric Le Goater <clg at kaod.org> wrote:
>> This can be used to easily identify a chip on a system with multiple
>> chips.
>>
>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> 
> Our userspace benefits from having this.
> 
> Acked-by: Joel Stanley <joel at jms.id.au>

Shouldn't such thing be part of core code then ?

>> ---
>>  drivers/mtd/spi-nor/aspeed-smc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
>> index 99302b0d7786..9119c0ca86b6 100644
>> --- a/drivers/mtd/spi-nor/aspeed-smc.c
>> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
>> @@ -676,6 +676,8 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller,
>>                 nor->prepare = aspeed_smc_prep;
>>                 nor->unprepare = aspeed_smc_unprep;
>>
>> +               mtd->name = of_get_property(child, "label", NULL);
>> +
>>                 ret = aspeed_smc_chip_setup_init(chip, r);
>>                 if (ret)
>>                         break;
>> --
>> 2.7.4
>>


-- 
Best regards,
Marek Vasut



More information about the linux-mtd mailing list