[PATCH v3 1/5] mtd: spi-nor: add memory controllers for the Aspeed AST2500 SoC

[Joel Stanley]

On Sat, Dec 10, 2016 at 3:49 AM, Cédric Le Goater <clg at kaod.org> wrote:
> This driver adds mtd support for the Aspeed AST2500 SoC static memory
> controllers :


> Based on previous work from Milton D. Miller II <miltonm at us.ibm.com>
>
> Signed-off-by: Cédric Le Goater <clg at kaod.org>

I had a read and it looks good. Once you have addressed Marek's
review, please add:

Reviewed-by: Joel Stanley <joel at jms.id.au>

> ---
>  drivers/mtd/spi-nor/Kconfig      |  10 +
>  drivers/mtd/spi-nor/Makefile     |   1 +
>  drivers/mtd/spi-nor/aspeed-smc.c | 735 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 746 insertions(+)
>  create mode 100644 drivers/mtd/spi-nor/aspeed-smc.c
>

> +
> +MODULE_DESCRIPTION("ASPEED Static Memory Controller Driver");
> +MODULE_AUTHOR("Milton Miller");

You can stick your name here instead, or drop the define.

> +MODULE_LICENSE("GPL v2");
> --
> 2.7.4
>