[PATCH V2] nandwrite: Factor out buffer checking code

David Oberhollenzer david.oberhollenzer at sigma-star.at
Fri Dec 9 00:25:20 PST 2016


On 12/09/2016 08:49 AM, Boris Brezillon wrote:
> On Fri,  9 Dec 2016 02:47:41 +0100
> Marek Vasut <marex at denx.de> wrote:
> 
>> Pull the buffer content checking code into separate function and
>> simplify the code invoking it slightly.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Boris Brezillon <boris.brezillon at free-electrons.com>
> 
> Reviewed-by: Boris Brezillon <boris.brezillon at free-electrons.com>

Looks good to me too.

On 12/09/2016 02:49 AM, Marek Vasut wrote:
> OK, done and V2 out. But it'd be great if someone could actually test it
> :-) Kees ?
> 
> 

>From looking at the code, it looks perfectly reasonable and I don't see
why it shouldn't work.

Anyway, I took the code snippet and ran an exhaustive test on all 32 bit
integers. It appears to work as intended.

Applied to mtd-utils.git.


Thanks,

David




More information about the linux-mtd mailing list