[PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed

Brian Norris computersforpeace at gmail.com
Mon Aug 29 12:57:45 PDT 2016


On Mon, Aug 15, 2016 at 05:22:00PM +0200, Boris Brezillon wrote:
> On Mon, 15 Aug 2016 10:47:39 +0300
> Roger Quadros <rogerq at ti.com> wrote:
> 
> > dma_request_chan() can fail returning an error pointer. In this case
> > prevent calling dma_release_channel() to prevent a ERR_PTR() dereference.
> > 
> > As error path can be called even with no DMA configuration, info->dma can
> > be NULL so don't call dma_release_channel() for that case either.
> > 
> > Fixes: de3bfc4a1616: ("mtd: nand: omap2: fix return value check in omap_nand_probe()")
> > Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> > Signed-off-by: Roger Quadros <rogerq at ti.com>
> 
> Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> 
> Brian, can you apply this fix directly?

Applied to linux-mtd.git



More information about the linux-mtd mailing list