[PATCH 0699/1285] Replace numeric parameter like 0444 with macro

Baole Ni baolex.ni at intel.com
Tue Aug 2 04:37:51 PDT 2016


I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com>
Signed-off-by: Baole Ni <baolex.ni at intel.com>
---
 drivers/mtd/mtdoops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
index 97bb8f6..ec55c4a 100644
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c
@@ -40,17 +40,17 @@
 #define MTDOOPS_HEADER_SIZE   8
 
 static unsigned long record_size = 4096;
-module_param(record_size, ulong, 0400);
+module_param(record_size, ulong, S_IRUSR);
 MODULE_PARM_DESC(record_size,
 		"record size for MTD OOPS pages in bytes (default 4096)");
 
 static char mtddev[80];
-module_param_string(mtddev, mtddev, 80, 0400);
+module_param_string(mtddev, mtddev, 80, S_IRUSR);
 MODULE_PARM_DESC(mtddev,
 		"name or index number of the MTD device to use");
 
 static int dump_oops = 1;
-module_param(dump_oops, int, 0600);
+module_param(dump_oops, int, S_IRUSR | S_IWUSR);
 MODULE_PARM_DESC(dump_oops,
 		"set to 1 to dump oopses, 0 to only dump panics (default 1)");
 
-- 
2.9.2




More information about the linux-mtd mailing list