[RESEND PATCH v2 01/27] mtd-utils: Restructure the mtd-utils source.

Dongsheng Yang yangds.fnst at cn.fujitsu.com
Fri Oct 30 19:38:20 PDT 2015


On 10/28/2015 07:00 AM, Brian Norris wrote:
> On Thu, Oct 15, 2015 at 12:10:08PM +0800, Dongsheng Yang wrote:
>> * There is no code modification in this commit, only moving
>> * the files to proper place.
>>
>> The user tools looks a little messy as we place almost
>> the all tools in the root directory of mtd-utils. To make
>> it more clear, I propose to introduce the following structure
>> for our source code.
>>
>> mtd-utils/
>> 	|-- lib
>> 	|-- include
>> 	|-- misc-utils
>> 	|-- flash-utils
>
> What's the difference between flash-utils and misc-utils? And don't just
> tell me it's because they were named starting with "flash" :)

Haha, I am afraid yes.
>
> Particularly, I think things like "mtdpart" and "flash_erase" are pretty
> similar levels of generic.

Agreed, I thought the flash_xxx is working in lower level than mtd_xxx.
But I found I was wrong. The are in a similar level. I will move
flash_xxx to misc-utils then.
>
> (Also, why is mtdinfo in ubi-utils still? It should be moved, IMO.)

This would be done after this restructure, then we have to move some
header files from ubi-utils to the top level and then move mtdinfo to 
misc-utils.
>
>> 	|-- jffsX-utils
>
> What makes more sense: jffsX or just jffs?

Hmmmm, I prefer jffsX for jffs and jffs2.
>
>> 	|-- nand-utils
>> 	|-- nor-utils
>
> What are specific to NOR flash? I don't even know what "rfddump" and
> "rfdformat" are. Do they really deserve their own directory?

I just read the helper of them "Formats NOR flash for resident flash
disk". Then I think there should be a nor-utils at the same time
with nand-utils.
>
>> 	|-- ubi-utils
>> 	|-- ubifs-utils
>> 	`-- tests
>
> You need to update .gitignore too.

Oh, yes, will update it.

TBH, I am not familiar with the *all* tools in our mtd-utils, so
I sent a RFC out to get more information for what I am not sure
about. But unfortunately, no response except yours.

I will send a V2 soon.

Thanx
Yang
>
> Brian
> .
>




More information about the linux-mtd mailing list