[PATCH v2 3/3] mtd: tests: introduce a erase test

Dongsheng Yang yangds.fnst at cn.fujitsu.com
Mon Oct 19 18:42:34 PDT 2015


On 10/20/2015 09:20 AM, Brian Norris wrote:
> On Mon, Oct 19, 2015 at 06:18:13PM -0700, Brian Norris wrote:
>> + others
>
> really +others this time!
>
>> On Wed, Sep 30, 2015 at 09:01:21AM +0800, Dongsheng Yang wrote:
>>> This test will test the below cases.
>>>
[...]
>>> +
>>> +MODULE_DESCRIPTION("Erase test module");
>>> +MODULE_AUTHOR("Dongsheng Yang");
>>> +MODULE_LICENSE("GPL");
>>
>> Overall, I'm not sure if this test is really that useful. It does a few
>> sanity checks on the API, but it doesn't really test the erase function
>> itself. If anyone else thinks this test is interesting though, I suppose
>> there's not much harm in putting it into mtd-utils tests/.

Yes, I found the erase problem about mtdram in my debugging. Then
I was wondering why we did not find it by running mtd/tests. Finally
I found there is no testing about it in mtd/tests. So write one and
send it out here.

As you said, it's much more proper to put them in mtd-utils. I am
totally agree with that. would port it to userspace.

Thanx
Yang
>>
>> Brian
> .
>




More information about the linux-mtd mailing list