[PATCH 1/2] mtd: pxa3xx_nand: don't duplicate MTD suspend/resume

Ezequiel Garcia ezequiel at vanguardiasur.com.ar
Fri Oct 16 08:26:54 PDT 2015


On 15 Oct 03:33 PM, Ezequiel Garcia wrote:
> Robert:
> 
> Can you test this on a platform with PM support, and make sure
> the NAND works fine after a resume?
> 
> On 12 October 2015 at 17:33, Brian Norris <computersforpeace at gmail.com> wrote:
> > mtd_{suspend,resume}() get called from mtdcore in a class suspend/resume
> > callback. We don't need to call them again here. In practice, this would
> > actually work OK, as nand_base actually handles nesting OK -- it just
> > might print warnings.
> >
> > Untested, but there are few (no?) users of PM for this driver AFAIK.
> >

Brian,

We discussed this on IRC, but I completely forgot about it :/

Without this patch nand_{suspend, resume} is called twice
(which seems harmless), tested on Armada XP-GP using nandtest.

Tested-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
Acked-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar



More information about the linux-mtd mailing list