[PATCH 1/2] mtd: fsl-quadspi: fix printk() format warning for size_t

Han Xu xhnjupt at gmail.com
Tue Oct 13 14:22:06 PDT 2015


On Mon, Oct 12, 2015 at 3:35 PM, Brian Norris
<computersforpeace at gmail.com> wrote:
> Seen when compile-testing on non-32-bit arch:
>
>     CC      drivers/mtd/spi-nor/fsl-quadspi.o
>   drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_read':
>   drivers/mtd/spi-nor/fsl-quadspi.c:873:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'size_t' [-Wformat=]
>     dev_dbg(q->dev, "cmd [%x],read from 0x%p, len:%d\n",
>     ^
>
> Also drop the '0x' prefixing to the '%p' formatter, since %p already
> knows how to format pointers appropriately.
>
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> Cc: Han Xu <han.xu at freescale.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 2954f89fc8be..ca259faf4591 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -868,7 +868,7 @@ static int fsl_qspi_read(struct spi_nor *nor, loff_t from,
>                 }
>         }
>
> -       dev_dbg(q->dev, "cmd [%x],read from 0x%p, len:%d\n",
> +       dev_dbg(q->dev, "cmd [%x],read from %p, len:%zd\n",
>                 cmd, q->ahb_addr + q->chip_base_addr + from - q->memmap_offs,
>                 len);
>
Acked-by: Han xu <han.xu at freescale.com>
> --
> 2.6.0.rc2.230.g3dd15c0
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



More information about the linux-mtd mailing list