[PATCH v2 05/60] mtd: devices: m25p80: show parent device in sysfs
Brian Norris
computersforpeace at gmail.com
Tue Oct 13 10:37:17 PDT 2015
On Wed, Jun 10, 2015 at 10:38:19PM +0200, Frans Klaver wrote:
> Fix a bug where mtd parent device symlinks aren't shown in sysfs.
>
> Signed-off-by: Frans Klaver <fransklaver at gmail.com>
This is one of the patches that didn't apply...
> ---
> drivers/mtd/devices/m25p80.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 3af137f..dfa6ee0 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -206,6 +206,7 @@ static int m25p_probe(struct spi_device *spi)
>
> spi_set_drvdata(spi, flash);
> flash->mtd.priv = nor;
> + flash->mtd.dev.parent = &spi->dev;
...but I don't think this patch is actually necessary. See
spi_nor_scan(), which assigns mtd->dev.parent for us. So as long as the
driver assigns the spi_nor::dev field, the spi-nor framework handles
this for us.
Same comment applies to fsl-quadspi.c (patch 59), which also didn't
apply cleanly. So I don't think we need either of these patches.
> flash->spi = spi;
>
> if (spi->mode & SPI_RX_QUAD)
Regards,
Brian
More information about the linux-mtd
mailing list