[PATCH 10/27] ubifs: introduce list.h

Dongsheng Yang yangds.fnst at cn.fujitsu.com
Wed Oct 7 17:02:40 PDT 2015


On 10/08/2015 04:41 AM, Richard Weinberger wrote:
> Am 19.08.2015 um 10:39 schrieb Dongsheng Yang:
>> Copy the list.h from kernel to ubifs-utils/
>>
>> Signed-off-by: Dongsheng Yang <yangds.fnst at cn.fujitsu.com>
>> ---
>>   ubifs-utils/include/list.h | 484 +++++++++++++++++++++++++++++++++++++++++++++
>
> This belongs to common mtd-utils code as it is not UBIFS specific.

Yes, It's in my TODO, but I did not put it at this time, because
there is a list implementation in jffs2 part, IIRC. So I am planing
to do it later to move all common code into higher level.
> And why didn't you copy the whole list.h file?

Hmmmm.....I only implemented what I required in this patchset. The 
commit message is confusing, It's not a *copy* from kernel. Maybe
it's better that "Implement list structure in ubifs-utils like kernel."

> I'm missing
> list_last_entry() for example.

If you want something more, I think it's okey to add them into list.h

Thanx
Yang

>
> Thanks,
> //richard
>




More information about the linux-mtd mailing list