[PATCH 23/39] UBI: drop null test before destroy functions
Richard Weinberger
richard at nod.at
Sat Oct 3 11:36:24 PDT 2015
Am 13.09.2015 um 14:15 schrieb Julia Lawall:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
>
> ---
> drivers/mtd/ubi/attach.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
> index 68eea5b..c1aaf03 100644
> --- a/drivers/mtd/ubi/attach.c
> +++ b/drivers/mtd/ubi/attach.c
> @@ -1209,9 +1209,7 @@ static void destroy_ai(struct ubi_attach_info *ai)
> }
> }
>
> - if (ai->aeb_slab_cache)
> - kmem_cache_destroy(ai->aeb_slab_cache);
> -
> + kmem_cache_destroy(ai->aeb_slab_cache);
> kfree(ai);
> }
Applied!
Thanks,
//richard
More information about the linux-mtd
mailing list