[PATCH 2/4] mtd: nand: sunxi: add missing of_node_put
Boris Brezillon
boris.brezillon at free-electrons.com
Mon Nov 23 05:59:15 PST 2015
On Wed, 18 Nov 2015 23:04:12 +0100
Julia Lawall <Julia.Lawall at lip6.fr> wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
>
> for_each_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> (
> return child;
> |
> + of_node_put(child);
> ? return ...;
> )
> ...
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
Thanks,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the linux-mtd
mailing list