[PATCH v2 3/5] mkfs.ubifs: simplify make_path with xasprintf
Marc Kleine-Budde
mkl at pengutronix.de
Thu Nov 12 01:31:26 PST 2015
From: Sascha Hauer <s.hauer at pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
Reviewed-by: Daniel Walter <dwalter at sigma-star.at>
Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
---
ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
index 049219b52cc5..a99c61382304 100644
--- a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
+++ b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
@@ -227,13 +227,9 @@ static char *make_path(const char *dir, const char *name)
{
char *s;
- s = malloc(strlen(dir) + strlen(name) + 2);
- if (!s)
- return NULL;
- strcpy(s, dir);
- if (dir[strlen(dir) - 1] != '/')
- strcat(s, "/");
- strcat(s, name);
+ xasprintf(&s, "%s%s%s",
+ dir, dir[strlen(dir) - 1] == '/' ? "" : "/", name);
+
return s;
}
--
2.6.1
More information about the linux-mtd
mailing list