[PATCH] mtd: zero out mtd_partion struct before using it
Brian Norris
computersforpeace at gmail.com
Wed Nov 11 16:47:52 PST 2015
It's easier to guarantee we've cleared out all unused fields with
memset() than by manually initializing each field.
Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
I hit this while testing out the added 'of_node' field:
http://patchwork.ozlabs.org/patch/538838/
drivers/mtd/mtdpart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index c2b6e967a160..3ace53342fd2 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -597,11 +597,10 @@ int mtd_add_partition(struct mtd_info *master, const char *name,
if (length <= 0)
return -EINVAL;
+ memset(&part, 0, sizeof(part));
part.name = name;
part.size = length;
part.offset = offset;
- part.mask_flags = 0;
- part.ecclayout = NULL;
new = allocate_partition(master, &part, -1, offset);
if (IS_ERR(new))
--
2.6.0.rc2.230.g3dd15c0
More information about the linux-mtd
mailing list