[PATCH] mtd: brcmnand: Fix NAND_CMD_PARAM byte order

Clay McClure clay at daemons.net
Mon Nov 2 15:10:05 PST 2015


On Tue, Oct 27, 2015 at 1:40 PM, Brian Norris
<computersforpeace at gmail.com> wrote:

>> If we continue to use LE APB
>> transfers, then I think we can exclude the be32_to_cpu() call from
>> Brian's patch.
>
> I don't believe we can safely drop the be32_to_cpu(). That is just a
> refactoring of the existing logic. Please stop suggesting ways to break
> STB SoCs.

Yes, you're right; I misunderstood your patch. Thanks for your patient
explanation! :-)

>> Brian, I'll test a variation of this patch on our iProc-based
>> platforms and report back.
>
> OK, getting testing feedback from an iProc-based system using ONFI would
> be somewhat illuminating.

I've tested your refactoring patch [1] on Helix4 (an iProc-based
switch chip); seems to work fine.

Thanks,

Clay

[1] http://patchwork.ozlabs.org/patch/536148/



More information about the linux-mtd mailing list