[PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.
Brian Norris
computersforpeace at gmail.com
Fri May 22 00:25:05 PDT 2015
(trimming CC a little this time, though it's still a bit large)
On Fri, May 22, 2015 at 12:17:27AM -0700, Brian Norris wrote:
> Admittedly, as he's using an out-of-tree driver, I'm not
> sure I know exactly what failure modes he is hitting yet.
Sorry, I realized I misread here. He's using spi-sunxi. Given that...
... is this code even valid?
static int sun6i_spi_transfer_one(struct spi_master *master,
struct spi_device *spi,
struct spi_transfer *tfr)
{
...
/* We don't support transfer larger than the FIFO */
if (tfr->len > SUN6I_FIFO_DEPTH)
return -EINVAL;
Seems like it should be looping over the transfer in multiple chunks
instead.
Brian
More information about the linux-mtd
mailing list